API-39286-rename-poa-pdf #18259
Merged
API-39286-rename-poa-pdf #18259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates naming for v1 2122 POA forms. * Adds optional param in bd.rb to handle tracking api version being used * Adds test for new naming pattern modified: modules/claims_api/app/sidekiq/claims_api/v1/poa_form_builder_job.rb modified: modules/claims_api/lib/bd/bd.rb modified: modules/claims_api/spec/lib/claims_api/bd_spec.rb
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
va-vfs-bot
temporarily deployed
to
API-39286-rename-poa-pdf/main/main
tycol7
reviewed
Aug 30, 2024
tycol7
reviewed
Aug 30, 2024
…to track when the job is triggered from that spot
va-vfs-bot
temporarily deployed
to
API-39286-rename-poa-pdf/main/main
| @@ -12,14 +12,14 @@ class PoaVBMSUploadJob < ClaimsApi::ServiceBase | |||
| # If successfully uploaded, it queues a job to update the POA code in BGS, as well. | |||
| # | |||
| # @param power_of_attorney_id [String] Unique identifier of the submitted POA | |||
| def perform(power_of_attorney_id) | |||
| def perform(power_of_attorney_id, action: 'post') | |||
There was a problem hiding this comment.
Has approx 12 statements - TooManyStatements
| it 'the fileName ends in representative.pdf' do | ||
| expect(json_body['data']['fileName']).to end_with('_representative.pdf') | ||
| end | ||
| end |
There was a problem hiding this comment.
Not entirely sure this second test is needed since this scenario shouldn't happen. Wanted to include it just to be safe. If anyone feels strongly about removing it I am open to that but wanted to error on the side of playing it safe and making sure this would be handled.
va-vfs-bot
temporarily deployed
to
API-39286-rename-poa-pdf/main/main
tycol7
previously approved these changes
Sep 4, 2024
Comment on lines
158
to
159
| context 'the doc type is 21-22' do | ||
| let(:pdf_path) { 'modules/claims_api/spec/fixtures/21-22A/signed_filled_final.pdf' } |
There was a problem hiding this comment.
Would this be
Suggested change
| context 'the doc type is 21-22' do | |
| let(:pdf_path) { 'modules/claims_api/spec/fixtures/21-22A/signed_filled_final.pdf' } | |
| context 'the doc type is 21-22' do | |
| let(:pdf_path) { 'modules/claims_api/spec/fixtures/21-22/signed_filled_final.pdf' } |
for completenessʼ sake?
There was a problem hiding this comment.
Yep, nice catch, committed it
Co-authored-by: Tyler <[email protected]>
github-actions
bot
added
ready-for-backend-review
and removed
ready-for-backend-review
test-passing
labels
rockwellwindsor-va
requested review from
a team
and removed request for
a team
tycol7
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
API-39286
Testing done
Testing notes
_representativereplacing the doc typeWhat areas of the site does it impact?
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?